Update to swift 4.2 #590
Merged
Update to swift 4.2 #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) To Swift 4.2 2) with current implementation of getting Remote token
|
Thanks for this migration work @redcapua! |
|
This shouldn't be merged yet. Our test infra doesn't support Xcode 10 or Swift 4.2. There is an update I can push which checks for swift version and works for both 4.2 and 4. I've been holding off on it to move to 4.2 straight when our infra is updated. I should've commented earlier. |
morganchen12
added a commit
to morganchen12/quickstart-ios
that referenced
this pull request
Dec 3, 2018
ulukaya
added a commit
that referenced
this pull request
Dec 4, 2018
Revert "Merge pull request #590 from redcapua/update-to-Swift-4.2"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to swift 4.2 according to issue #568